why did terezi tell her past self not to date dave?

She didn’t, it was John who suggested that she refrain from dating him. Her not dating Dave allowed him and Karkat to become friends immediately instead of being at odds over Terezi.