If they never get out and are trapped forever how will John die? Doc Scratch was reasonably sure that when John died, it wouldn't be as a scoundrel, indicating that he will die, and not live in, infinite house hell.

Doc Scratch just meant that if/when John died for good it would be a Heroic death and not a Just one. Because John is a good egg.